From 9d4c31162db6e491c69f517d88f77a4ea5d100a6 Mon Sep 17 00:00:00 2001 From: Ziyang Zhou Date: Sun, 9 May 2021 23:09:00 +0800 Subject: [PATCH 1/6] fix booting --- init/first_stage_init.cpp | 20 ++++++++++++++++---- init/service.cpp | 3 ++- init/util.cpp | 3 ++- rootdir/init.rc | 1 - 4 files changed, 20 insertions(+), 7 deletions(-) diff --git a/init/first_stage_init.cpp b/init/first_stage_init.cpp index 107e99a..e6d9601 100644 --- a/init/first_stage_init.cpp +++ b/init/first_stage_init.cpp @@ -35,6 +35,7 @@ #include #include #include +#include #include #include @@ -243,6 +244,8 @@ int FirstStageMain(int argc, char** argv) { CHECKCALL(mkdir("/dev/pts", 0755)); CHECKCALL(mkdir("/dev/socket", 0755)); CHECKCALL(mkdir("/dev/dm-user", 0755)); + mount("/system/etc", "/etc", "none", MS_BIND, NULL); // cgroup fix + unshare(CLONE_NEWCGROUP); CHECKCALL(mount("devpts", "/dev/pts", "devpts", 0, NULL)); #define MAKE_STR(x) __STRING(x) CHECKCALL(mount("proc", "/proc", "proc", 0, "hidepid=2,gid=" MAKE_STR(AID_READPROC))); @@ -306,7 +309,6 @@ int FirstStageMain(int argc, char** argv) { for (const auto& [error_string, error_errno] : errors) { LOG(ERROR) << error_string << " " << strerror(error_errno); } - LOG(FATAL) << "Init encountered errors starting first stage, aborting"; } LOG(INFO) << "init first stage started!"; @@ -401,7 +403,7 @@ int FirstStageMain(int argc, char** argv) { } if (!DoFirstStageMount(!created_devices)) { - LOG(FATAL) << "Failed to mount required partitions early ..."; + LOG(ERROR) << "Failed to mount required partitions early ..."; } struct stat new_root_info; @@ -420,12 +422,22 @@ int FirstStageMain(int argc, char** argv) { 1); const char* path = "/system/bin/init"; - const char* args[] = {path, "selinux_setup", nullptr}; + std::vector args = {path, "second_stage"}; + std::string init_cmdline; + android::base::ReadFileToString("/proc/self/cmdline", &init_cmdline); + std::replace(init_cmdline.begin(), init_cmdline.end(), '\0', ' '); + auto cmd_vector = android::base::Split(android::base::Trim(init_cmdline), " "); + int i = 0; + for (const auto& entry : cmd_vector) { + if (i++ == 0) continue; // ignore first arg '/init' + args.push_back(entry.c_str()); + } + args.push_back(nullptr); auto fd = open("/dev/kmsg", O_WRONLY | O_CLOEXEC); dup2(fd, STDOUT_FILENO); dup2(fd, STDERR_FILENO); close(fd); - execv(path, const_cast(args)); + execv(path, const_cast(args.data())); // execv() only returns if an error happened, in which case we // panic and never fall through this conditional. diff --git a/init/service.cpp b/init/service.cpp index 35beaad..3bdf7c2 100644 --- a/init/service.cpp +++ b/init/service.cpp @@ -75,6 +75,7 @@ namespace android { namespace init { static Result ComputeContextFromExecutable(const std::string& service_path) { + se_hack1("HACKED"); std::string computed_context; char* raw_con = nullptr; @@ -371,7 +372,7 @@ void Service::Reap(const siginfo_t& siginfo) { if (!GetBoolProperty("init.svc_debug.no_fatal." + name_, false)) { // Aborts into `fatal_reboot_target_'. SetFatalRebootTarget(fatal_reboot_target_); - LOG(FATAL) << "critical process '" << name_ << "' exited 4 times " + LOG(ERROR) << "critical process '" << name_ << "' exited 4 times " << exit_reason; } } else { diff --git a/init/util.cpp b/init/util.cpp index bc8ea6e..78d76a2 100644 --- a/init/util.cpp +++ b/init/util.cpp @@ -242,7 +242,8 @@ int wait_for_file(const char* filename, std::chrono::nanoseconds timeout) { void ImportKernelCmdline(const std::function& fn) { std::string cmdline; - android::base::ReadFileToString("/proc/cmdline", &cmdline); + android::base::ReadFileToString("/proc/self/cmdline", &cmdline); // HACKED + std::replace(cmdline.begin(), cmdline.end(), '\0', ' '); // HACKED for (const auto& entry : android::base::Split(android::base::Trim(cmdline), " ")) { std::vector pieces = android::base::Split(entry, "="); diff --git a/rootdir/init.rc b/rootdir/init.rc index 7da2646..5f804c2 100644 --- a/rootdir/init.rc +++ b/rootdir/init.rc @@ -571,7 +571,6 @@ on post-fs # Once everything is setup, no need to modify /. # The bind+remount combination allows this to work in containers. - mount rootfs rootfs / remount bind ro nodev # Mount default storage into root namespace mount none /mnt/user/0 /storage bind rec -- 2.45.1